-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sbml qual models #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tical order for a concept
…nd refer to species id rather than the name field
… to regnet, add regnet amrs for sbml qual documents from the covid-19 diseasemap
…tionary for each controller, rerun script to generate new qual regnet amr for covid-19 disease map
…ript to regenerate qual regnet amr
nanglo123
force-pushed
the
sbml_qual_support
branch
from
April 25, 2024 14:09
bc7e7d9
to
6ebf100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for SBML Qual documents and turns them into semantically equivalent MIRA template models.
Models derived from SBML Qual documents do have an empty
parameters
,compartments
, andunit_definitions
attribute. There is now an API for extracting template models from SBML Qual documents which has been added to the documentation and two smoke tests have been added to ensure that we can extract a template model from Qual documents found here:https://git-r3lab.uni.lu/covid/models/-/tree/master/Executable%20Modules/SBML_qual_build/sbml?ref_type=heads
and to also extract template models from biomodels: BIOMD0000000562, BIOMD0000000592, and BIOMD0000000593. A script has been added as well to retrieve all the sbml qual documents from the covid-19 disease map and to convert them to regnet amrs.
This PR also changes the way in which we export regnet amrs. We now process each upstream controller present in a grouped type template and create an edge for each of them. To account for the duplication of rates that would occur when we process all upstream controllers, we set the expression for any subsequent rate added to the regnet amr processed from the same transition to 0 after the first one has been added. Affected regnet amrs from evaluation_2024.03 and hackathon_2024.02 due ot this change have been regenerated as well.
Additionally shared functionality for processing SBML and SBML Qual documents have been added to a
utils.py
file in the sbml directory.